<html>
<head><meta charset="utf-8"><title>Testing lints for rustdoc · rustdoc · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/index.html">rustdoc</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/Testing.20lints.20for.20rustdoc.html">Testing lints for rustdoc</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="219681957"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/Testing%20lints%20for%20rustdoc/near/219681957" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Poliorcetics <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/Testing.20lints.20for.20rustdoc.html#219681957">(Dec 12 2020 at 01:33)</a>:</h4>
<p>I'll go to sleep very soon so this is not urgent in any way but I'll want to write tests for <a href="https://github.com/rust-lang/rust/pull/79816">https://github.com/rust-lang/rust/pull/79816</a> next and I don't know where and how lints are tested for rustdoc</p>



<a name="219681969"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/Testing%20lints%20for%20rustdoc/near/219681969" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Poliorcetics <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/Testing.20lints.20for.20rustdoc.html#219681969">(Dec 12 2020 at 01:33)</a>:</h4>
<p>Where can I find the information/an example ?</p>



<a name="219682028"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/Testing%20lints%20for%20rustdoc/near/219682028" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/Testing.20lints.20for.20rustdoc.html#219682028">(Dec 12 2020 at 01:34)</a>:</h4>
<p>probably somewhere in src/test/rustdoc-ui? this part of rustdoc isn't tested well</p>



<a name="219682043"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/Testing%20lints%20for%20rustdoc/near/219682043" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/Testing.20lints.20for.20rustdoc.html#219682043">(Dec 12 2020 at 01:35)</a>:</h4>
<p>yeah this looks about right:</p>
<div class="codehilite"><pre><span></span><code>$ ls ~/rustc/src/test/rustdoc-ui/*lint*
/home/joshua/rustc/src/test/rustdoc-ui/lint-group.rs
/home/joshua/rustc/src/test/rustdoc-ui/lint-group.stderr
/home/joshua/rustc/src/test/rustdoc-ui/lint-missing-doc-code-example.rs
/home/joshua/rustc/src/test/rustdoc-ui/lint-missing-doc-code-example.stderr
/home/joshua/rustc/src/test/rustdoc-ui/no-crate-level-doc-lint.rs
/home/joshua/rustc/src/test/rustdoc-ui/no-crate-level-doc-lint.stderr
/home/joshua/rustc/src/test/rustdoc-ui/pub-export-lint.rs
/home/joshua/rustc/src/test/rustdoc-ui/pub-export-lint.stderr
/home/joshua/rustc/src/test/rustdoc-ui/unknown-renamed-lints.rs
/home/joshua/rustc/src/test/rustdoc-ui/unknown-renamed-lints.stderr
/home/joshua/rustc/src/test/rustdoc-ui/unused-braces-lint.rs
</code></pre></div>



<a name="219682129"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/Testing%20lints%20for%20rustdoc/near/219682129" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/Testing.20lints.20for.20rustdoc.html#219682129">(Dec 12 2020 at 01:36)</a>:</h4>
<p>wow github's ui is so bad sometimes - I typed <code>r? @jyn514</code> and hit tab by reflex and it changed it to <code>r? @poliorcetics</code> lmao</p>



<a name="219682507"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/Testing%20lints%20for%20rustdoc/near/219682507" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/Testing.20lints.20for.20rustdoc.html#219682507">(Dec 12 2020 at 01:45)</a>:</h4>
<p>left a review</p>



<a name="219707470"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/Testing%20lints%20for%20rustdoc/near/219707470" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> GuillaumeGomez <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/Testing.20lints.20for.20rustdoc.html#219707470">(Dec 12 2020 at 12:51)</a>:</h4>
<p>The problem is that rustdoc initially didn't use the compiler error system, I added it "recently" (a year ago? Maybe more? No idea) and didn't update all errors yet</p>



<a name="219707517"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/Testing%20lints%20for%20rustdoc/near/219707517" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> GuillaumeGomez <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/Testing.20lints.20for.20rustdoc.html#219707517">(Dec 12 2020 at 12:52)</a>:</h4>
<p>but at least, the errors using the "new" error system are all tested, and if more are added/updated to this error system, we'll need to test them all as well :)</p>



<a name="219708193"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/Testing%20lints%20for%20rustdoc/near/219708193" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/Testing.20lints.20for.20rustdoc.html#219708193">(Dec 12 2020 at 13:08)</a>:</h4>
<p>Oh wow! I didn't realize you had to switch it, thank you for doing that :)</p>



<a name="219708931"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/Testing%20lints%20for%20rustdoc/near/219708931" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> GuillaumeGomez <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/Testing.20lints.20for.20rustdoc.html#219708931">(Dec 12 2020 at 13:26)</a>:</h4>
<p>Well, I wanted to add lints. Before that it was a bit weird. It remained the same for years until some day I realized that rustdoc had no lints nor "compilation errors"</p>



<a name="219708932"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/Testing%20lints%20for%20rustdoc/near/219708932" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> GuillaumeGomez <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/Testing.20lints.20for.20rustdoc.html#219708932">(Dec 12 2020 at 13:26)</a>:</h4>
<p>just some errors and exits</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>